[ << Issues ] | [Top][Contents][Index][ ? ] | [ Regression tests >> ] | ||
[ < Adding issues to the tracker ] | [ Up : Issues ] | [ Summary of project status > ] |
8.6 Patch handling
Note: This is not a Bug Squad responsibility; we have a separate person handling this task.
There is a single Patch Meister, and a number of Patch Helpers (rename this?). The list of known patches awaiting review is:
http://code.google.com/p/lilypond/issues/list?can=2&q=label:patch&sort=patch
Helpers: adding patches
The primary duty is to add patches to the google tracker; we have
a bad track record of losing patches in email. Patches generally
come to the lilypond-devel
mailing list, but are sometimes
sent to bug-lilypond
, lilypond-users
, or
frogs
mailing list instead.
-
Unless a patch is clearly in response to an existing issue, add a
new issue with the
Patch-new
label and a link to the patch (either on the mailing list archives or the codereview url).Issue numbers are cheap; losing developers because they got fed up with us losing their hard work is expensive.
-
If the patch is clearly in response to an existing issue, then
update that issue with the
Patch-new
label and a link to the patch (either on the mailing list archives or the codereview url). -
After adding the issue, please send a response email to the same
group(s) that the initial patch was sent to.
If the initial email was sent to multiple mailing lists (such as both
bugs
anddevel
), then reply to all those mailing lists as well. The email should contain a link to the issue you just added.
Helpers: Patch-review
label
The secondary duty is to do make sure that every issue in the
tracker with a Patch-review
label has passed these
“obvious” tests:
-
Applies automatically to git master.
It’s ok to have offsets, but not conflicts.
- Regtest comparison looks ok; no unexpected changes.
-
Descriptive subject line.
Avoid subjects like “fixes 123”; instead write “Doc: discuss stacking-dir for BassFigureAlignment (fix 123)”.
- Compiles docs from scratch. Only check this if you have reason to suspect it might not work.
-
(maybe)
Check code indentation and style. This should be easier post-GOP when we have a better-defined code style.
Patch Meister
The Patch Meister will:
-
send “countdown” emails to
lilypond-devel
when patches appear to be ready. - send general requests to review patches, or even nasty requests to review patches.
-
downgrade patches from
Patch-review
toPatch-needs_work
as appropriate. -
downgrade patches from
Patch-needs_work
toPatch-abandoned
if no actions have been taken in four weeks.
[ << Issues ] | [Top][Contents][Index][ ? ] | [ Regression tests >> ] | ||
[ < Adding issues to the tracker ] | [ Up : Issues ] | [ Summary of project status > ] |